Extract config_file method from action_class to enable external access #647
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damacus 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: damacus <[email protected]>
Copilot
AI
changed the title
[WIP] Extract useful methods to outside of action_class
Extract config_file method from action_class to enable external access
Sep 11, 2025
Copilot finished work on behalf of
damacus
September 11, 2025 23:16
damacus
requested changes
Sep 12, 2025
resources/site.rb
Outdated
Comment on lines
66
to
67
| def config_file | ||
| ::File.join(conf_dir, "#{name}.conf") |
There was a problem hiding this comment.
Extracted the config_file logic to a new nginx_site_config_file helper method in helpers.rb. The resource method now delegates to the helper while maintaining external accessibility. (13f62b2)
|
@copilot rebase |
Co-authored-by: damacus <[email protected]>
Copilot finished work on behalf of
damacus
October 31, 2025 08:37
Slowest examplesTop 10 slowest examples (0.95 seconds, 27.92% of total time)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.